Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal close button submits parent form #169

Closed
kennethj opened this issue Jan 10, 2019 · 1 comment · Fixed by #180
Closed

Modal close button submits parent form #169

kennethj opened this issue Jan 10, 2019 · 1 comment · Fixed by #180

Comments

@kennethj
Copy link
Member

If a modal component is nested in a <form> element, the close button will submit that form. I believe this can be fixed by adding a button type of "button" i.e. <button type="button">.

https://github.com/indiana-university/rivet-react/blob/develop/src/components/Modal/Modal.tsx#L28
@kennethj kennethj mentioned this issue Jan 10, 2019
Merged
burnumd added a commit that referenced this issue Jan 30, 2019
@burnumd
fix(Modal): Modal close button submits parent
6b3c631 
fixes #169
@burnumd burnumd mentioned this issue Jan 30, 2019
Merged
burnumd added a commit that referenced this issue Jan 30, 2019
@burnumd
fix(Modal): Modal close button submits parent (#180)
07711b1 
fixes #169
@iubot
Copy link
Member

iubot commented Jan 30, 2019

🎉 This issue has been resolved in version 0.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Modal): Modal close button submits parent indiana-university/rivet-react
2 participants
@kennethj @iubot