Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IndieBlocks #258

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add IndieBlocks #258

merged 1 commit into from
Mar 15, 2024

Conversation

pfefferle
Copy link
Member

@pfefferle pfefferle commented Mar 13, 2024

I like what @janboddez has done with blocks and I would remove the classic-editor and recommend to add it as dependency to the post-kinds plugin, because otherwise it is no requirement.

I like what @janboddez has done with blocks and I would remove the classic-editor and would recommend to add it as dependency to the post-kinds plugin, because otherwise it is no requirement.
@pfefferle pfefferle requested review from snarfed and dshanske March 13, 2024 16:44
@dshanske
Copy link
Member

I'm in favor of this. I agree the Classic Editor should be swapped over to a dependency. But I feel like we should add some text to the page to make clear there might be overlapping functionality between certain plugins.

@janboddez
Copy link

janboddez commented Mar 15, 2024

I feel like we should add some text to the page to make clear there might be overlapping functionality between certain plugins.

This seems important. There's definitely some "overlap" with Webmention, and Post Kinds. Or rather, despite IndieBlocks' different approach to these things, the various plugins can be made to work together quite nicely. It all depends on what is and isn't enabled.

People already using Webmention will want to disable IndieBlocks' Webmention functionality but may very well appreciate its Facepile block, or the microformats it adds to comments (including webmentions). That is if they are using a block theme. The Syndication block, too, can be made to work with Syndication Links. (Although block bindings could make the Syndication block redundant soon enough ... but that's a different story.)

@dshanske
Copy link
Member

I feel like we should add some text to the page to make clear there might be overlapping functionality between certain plugins.

This seems important. There's definitely some "overlap" with Webmention, and Post Kinds. Or rather, despite IndieBlocks' different approach to these things, the various plugins can be made to work together quite nicely. It all depends on what is and isn't enabled.

People already using Webmention will want to disable IndieBlocks' Webmention functionality but may very well appreciate its Facepile block, or the microformats it adds to comments (including webmentions). That is if they are using a block theme. The Syndication block, too, can be made to work with Syndication Links. (Although block bindings could make the Syndication block redundant soon enough ... but that's a different story.)

I hope you will monitor the Repo and comment on the proposal, and maybe add to it. I want to link to external resources, and have a good succinct built in explanation.

Copy link
Member

@dshanske dshanske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but don't want to deploy to the .org repo until extra text is added.

@dshanske dshanske merged commit 763ff63 into trunk Mar 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants