Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVM Memory Pool #587

Closed

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Jul 22, 2022

PR on top of #452


This currently fails with

File "/shared/home/mdiener/Work/emirge/grudge/examples/wave/wave-op-mpi.py", line 351, in <module>
    main(cl.create_some_context,
  File "/shared/home/mdiener/Work/emirge/grudge/examples/wave/wave-op-mpi.py", line 213, in main
    allocator=cl_tools.SVMMemoryPool(cl_tools.SVMAllocator(cl_ctx, cl.svm_mem_flags.READ_WRITE, queue=queue)),
TypeError: __init__(): incompatible constructor arguments. The following argument types are supported:
    1. pyopencl._cl.SVMMemoryPool(allocator: pyopencl._cl._tools_SVMAllocator, leading_bits_in_bin_id: int = 4)

Invoked with: <pyopencl.tools.SVMAllocator object at 0x7fadda3eb940>

cc @inducer @lukeolson

@inducer
Copy link
Owner

inducer commented Jul 22, 2022

Saw that you started working on this. I'd been working on this, too. I just pushed my WIP work to #452, in some ways similar to what you have here. FWIW, what's there doesn't even compile yet, but I figured it'd be better to share than not.

@inducer
Copy link
Owner

inducer commented Jul 22, 2022

(And sorry about the duplication of work!)

@inducer inducer mentioned this pull request Jul 22, 2022
9 tasks
@inducer inducer force-pushed the array-svm branch 4 times, most recently from 0cf016f to 465903d Compare July 31, 2022 21:52
@matthiasdiener
Copy link
Contributor Author

Closing since #452 already has an SVM pool now.

@matthiasdiener matthiasdiener deleted the array-svm-extras branch August 1, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants