Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds dependency tracking to individual exports. If an export A is only used inside another exported function B that is not used, the A export will also be marked as unused.
To detect whether an export is used inside another export, I copied the
ancestor()
walker from Acorn, so thesiftMember
method can check if any of the ancestors of the current node also assign an export.I added a parameter to
Module#isUsed()
when checking dependent uses, which tracks which dependencies have already been visited, to address recursive dependencies like:(Initially I used a
this.computingDependents
array for this purpose but that didn't work when a recursive dependency crossed module boundaries.)