Avoid circular dependency #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am having conflicts now between dependencies as some install 6.4.1 and the fix by @xg-wang is for 6.4.0. Could we merge this to regain sanity? Elliptic is a subdependency of my project and I don't have direct control over it. Thanks a lot |
|
@lemoustachiste you can try to install required elliptic version as a dependency of your project and then run |
|
yes that's what I am doing now and it works fine. But it's a bit tedious. |
|
@indutny friendly reminder that PR is ready to be merged :) |
|
Landed in dbe8bc6 and released in 6.5.0. Thank you, and sorry for delay! |
troggy
added a commit
to leapdao/ethereumjs-util
that referenced
this pull request
Feb 5, 2020
This version uses elliptic with fixed circular dependency. Because of that circular dependency it wasn't possible to use ethereumjs-util with rollup build tool Reference: indutny/elliptic#180
lemoustachiste
pushed a commit
to blockchain-certificates/cert-verifier-js
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are changes from #157 rebased to master