Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing checks during decoding of signatures leading to a certain degree of malleability of ECDSA and EDDSA signatures #317

Merged
merged 1 commit into from
Aug 14, 2024
+11 −0
Merged

Missing checks during decoding of signatures leading to a certain degree of malleability of ECDSA and EDDSA signatures #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/elliptic/ec/signature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ function getLength(buf, p) {
return false;
}

if(buf[p.place] === 0x00) {
return false;
}

var val = 0;
for (var i = 0, off = p.place; i < octetLen; i++, off++) {
val <<= 8;
Expand Down Expand Up @@ -86,6 +90,9 @@ Signature.prototype._importDER = function _importDER(data, enc) {
if (rlen === false) {
return false;
}
if ((data[p.place] & 128) !== 0) {
return false;
}
var r = data.slice(p.place, rlen + p.place);
p.place += rlen;
if (data[p.place++] !== 0x02) {
Expand All @@ -98,6 +105,9 @@ Signature.prototype._importDER = function _importDER(data, enc) {
if (data.length !== slen + p.place) {
return false;
}
if ((data[p.place] & 128) !== 0) {
return false;
}
var s = data.slice(p.place, slen + p.place);
if (r[0] === 0) {
if (r[1] & 0x80) {
Expand Down
1 change: 1 addition & 0 deletions lib/elliptic/eddsa/signature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ function Signature(eddsa, sig) {
sig = parseBytes(sig);

if (Array.isArray(sig)) {
assert(sig.length === eddsa.encodingLength * 2, 'Signature has invalid size');
sig = {
R: sig.slice(0, eddsa.encodingLength),
S: sig.slice(eddsa.encodingLength),
Expand Down