Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External input param #268

Merged
merged 1 commit into from
Sep 10, 2024
Merged

External input param #268

merged 1 commit into from
Sep 10, 2024

Conversation

cowan-macady
Copy link
Contributor

  • add input param and tests
  • add tests on external data

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (88d54d1) to head (f79f284).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   72.26%   72.26%           
=======================================
  Files          36       36           
  Lines        1583     1583           
=======================================
  Hits         1144     1144           
  Misses        381      381           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Sep 10, 2024

Here's the code health analysis summary for commits 88d54d1..f79f284. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cowan-macady cowan-macady requested review from jakubtomany and removed request for Septimus4 September 10, 2024 07:32
Copy link
Contributor

@jakubtomany jakubtomany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cowan-macady cowan-macady merged commit 9def30a into master Sep 10, 2024
11 checks passed
@cowan-macady cowan-macady deleted the external-input-param branch September 10, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants