-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update axios version #1116
Update axios version #1116
Conversation
@reinink Could this be merged and published please? Currently we have to have multiple Axios versions to use its latest features. |
@innocenzi Do you know if there are any breaking changes in these new versions that could affect Inertia? |
@reinink There is none, all breaking changes are mostly typescript declaration changes and dependency upgrades, if there was a breaking change affecting the APIs they would have released a major version |
Okay good to know 👍
Well these are technically major versions, since they are pre 1.0 still. |
There were a few breaking changes indeed but none that I think would affect Inertia (most of them were about types). |
I fixed and checked all the typing errors, they were caused by the Removal of type Any to the AxiosResponse, and indeed those type errors made perfect sense and were not caught before as those functions were returning |
There might be one thing to consider when upgrading, regarding "breaking changes". |
@RobertBoes Changing the cancelToken will introduce breaking changes to the inertia visit options, so yes would be best in a follow up PR |
Axios has published several new versions including security fixes https://github.com/axios/axios/releases