Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios version #1116

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Update axios version #1116

merged 2 commits into from
Mar 10, 2022

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Mar 1, 2022

Axios has published several new versions including security fixes https://github.com/axios/axios/releases

@innocenzi
Copy link
Contributor

@reinink Could this be merged and published please? Currently we have to have multiple Axios versions to use its latest features.

@reinink
Copy link
Member

reinink commented Mar 8, 2022

@innocenzi Do you know if there are any breaking changes in these new versions that could affect Inertia?

@Tofandel
Copy link
Contributor Author

Tofandel commented Mar 8, 2022

@reinink There is none, all breaking changes are mostly typescript declaration changes and dependency upgrades, if there was a breaking change affecting the APIs they would have released a major version

@reinink
Copy link
Member

reinink commented Mar 8, 2022

There is none, all breaking changes are mostly typescript declaration changes and dependency upgrades

Okay good to know 👍

if there was a breaking change affecting the APIs they would have released a major version

Well these are technically major versions, since they are pre 1.0 still.

@innocenzi
Copy link
Contributor

@innocenzi Do you know if there are any breaking changes in these new versions that could affect Inertia?

There were a few breaking changes indeed but none that I think would affect Inertia (most of them were about types).

@Tofandel
Copy link
Contributor Author

Tofandel commented Mar 8, 2022

I fixed and checked all the typing errors, they were caused by the Removal of type Any to the AxiosResponse, and indeed those type errors made perfect sense and were not caught before as those functions were returning string | false and not boolean

@RobertBoes
Copy link
Contributor

There might be one thing to consider when upgrading, regarding "breaking changes". cancelToken is now deprecated (although not directly mentioned in the release notes) as of v0.22.0, see axios/axios#3305 and https://axios-http.com/docs/cancellation. This probably isn't necessary for this PR, but I thought it might be worth mentioning. I can implement it in a follow-up PR

@Tofandel
Copy link
Contributor Author

Tofandel commented Mar 8, 2022

@RobertBoes Changing the cancelToken will introduce breaking changes to the inertia visit options, so yes would be best in a follow up PR

@reinink reinink merged commit 055c928 into inertiajs:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants