[1.x] Export InertiaFormProps in Vue and Svelte Adapters #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spice-King
added a commit
to Spice-King/precognition
that referenced
this pull request
Nov 22, 2023
Requires inertiajs/inertia#1734 to be published to a version.
Spice-King
added a commit
to Spice-King/precognition
that referenced
this pull request
Nov 22, 2023
Requires inertiajs/inertia#1734 to be published to a new version.
Spice-King
added a commit
to Spice-King/precognition
that referenced
this pull request
Nov 22, 2023
Requires inertiajs/inertia#1734 to be published to a new version.
Spice-King
added a commit
to Spice-King/precognition
that referenced
this pull request
Nov 22, 2023
Requires inertiajs/inertia#1734 to be published to a new version.
pedroborges
force-pushed
the
export-form-props
branch
from
4e81db3 to
54e0422
Compare
pedroborges
changed the title
pedroborges
approved these changes
Sep 23, 2024
|
@Spice-King Could you please confirm whether we need to export InertiaFormProps from the adapter's index files, as suggested in #1596? |
pedroborges
added
vue 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to solve type issues for a laravel/precognition PR that I'm creating. I blame Typescript for this, as for some reason, TS needs the type exported to be used as part of another packages exports, even indirectly, otherwise you can get TS error 4023. Precognition only does Vue 3, but also added it to Vue 2 for constancy reasons.