Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the full page object to resolve component #1864

Closed
wants to merge 1 commit into from

Conversation

james-em
Copy link

See discussion #1863

@driesvints driesvints requested a review from reinink April 22, 2024 10:21
@james-em
Copy link
Author

james-em commented May 1, 2024

May I pull your attention here? :) @reinink

I believe it's a really quick QA without any kind of side effect and I did it for all adapters and typescript types

@reinink
Copy link
Member

reinink commented May 6, 2024

Yup, I think this makes sense! Will test this out and let you know.

@james-em
Copy link
Author

james-em commented May 6, 2024

Yup, I think this makes sense! Will test this out and let you know.

Yup, I think this makes sense! Will test this out and let you know.

If you merge Svelte Typescript support, I will update this PR very quickly to include new Svelte types.

I can tell this works well for Svelte, been using this branch for 2 weeks about everyday

jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 12, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 16, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 28, 2024
jamesst20 added a commit to jamesst20/inertia that referenced this pull request May 28, 2024
@jamesst20
Copy link
Contributor

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

@reinink
Copy link
Member

reinink commented Sep 2, 2024

It appears to me the project Inertia is dead and there are no more reasons for me to keep my work open and maintain it.

I am closing all my opened PRs which includes #1864 #1872 #1873 #1874 #1875 #1881

I will be maintaining unofficially my own fork of this library so my projects using Svelte 5 can still live until I find or create an appropriate replacement for this library.

Thanks to everyone who spent time looking at my PRs.

Bummer dude 😕

We've been working really hard on Inertia.js v2.0 (as you can see in Taylor's Laracon keynote), so the project is far from dead — we're just in a bit of an awkward position between major versions.

I apologize that your work has not received more attention, that's partly my fault for not having enough time to review PRs recently. I don't work on Inertia.js full time like other open source maintainers (ie. Laravel, Livewire), so for me it actually requires time out of my personal life. Because of that things just take longer, as much as I wish it didn't.

Thanks for your contributions either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants