Fix types and remove use of deprecated browser event prop #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengslogar
reviewed
Jun 26, 2024
| @@ -67,10 +67,10 @@ const Link = forwardRef<unknown, InertiaLinkProps>( | |||
| ref, | |||
| ) => { | |||
| const visit = useCallback( | |||
| (event) => { | |||
| (event: React.MouseEvent) => { | |||
There was a problem hiding this comment.
Shouldn't this be a mouse or keyboard event? Tabbing onto a link/button and pressing "enter" can trigger a click
There was a problem hiding this comment.
I lied. It's still a mouse event. Carry on 😅
|
Thanks for all your work on this! Lots of learnings over the past few days for me 💪 |
|
@shengslogar me as well, thanks for collaborating with me on it! |
2 tasks
thecrypticace
approved these changes
Jun 28, 2024
|
Thanks guys!! |
derrickreimer
added a commit
that referenced
this pull request
Dec 12, 2024
In #1910 (d53b2b3), we switched to passing `event.nativeEvent` to `shouldIntercept` in an attempt to consistently always pass native browser events to this framework-agnostic helper. This actually introduced a bug though, because `currentTarget` is _different_ on React's synthetic event vs. the underlying native event. The correct value for `currentTarget` lives on the synthetic event. Since we are no longer relying on `event.which` (and this is the only property we used to be concerned with that was not included on the React synthetic event), we'll simply move back to passing the React synthetic event to `shouldIntercept`.
derrickreimer
added a commit
that referenced
this pull request
Dec 12, 2024
In #1910 (d53b2b3), we switched to passing `event.nativeEvent` to `shouldIntercept` in an attempt to consistently always pass native browser events to this framework-agnostic helper. This actually introduced a bug though, because `currentTarget` is _different_ on React's synthetic event vs. the underlying native event. The correct value for `currentTarget` lives on the synthetic event. Since we are no longer relying on `event.which` (and this is the only property we used to be concerned with that was not included on the React synthetic event), we'll simply move back to passing the React synthetic event to `shouldIntercept`.
reinink
pushed a commit
that referenced
this pull request
Dec 13, 2024
In #1910 (d53b2b3), we switched to passing `event.nativeEvent` to `shouldIntercept` in an attempt to consistently always pass native browser events to this framework-agnostic helper. This actually introduced a bug though, because `currentTarget` is _different_ on React's synthetic event vs. the underlying native event. The correct value for `currentTarget` lives on the synthetic event. Since we are no longer relying on `event.which` (and this is the only property we used to be concerned with that was not included on the React synthetic event), we'll simply move back to passing the React synthetic event to `shouldIntercept`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to some crafty sleuthing by @shengslogar (#1908 (comment)), there are a few things to clean up after #1908:
shouldInterceptfrom the React adapter was the React synthetic event, which does not have all the properties of the underlying native event. It seems wise to keep the intercept helper function framework-agnostic, so this change now passes theevent.nativeEventtoshouldIntercept.event.whichproperty is deprecated. The purpose it previously served for evaluatingMouseEventeligibility is now covered by the newly-introducedevent.buttoncheck.visitfunction and expanded theonClickprop signature (since this is a polymorphic element, this may not always be anHTMLAnchorElement).