Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/component deploy #2972

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

chongchuanbing
Copy link
Contributor

@chongchuanbing chongchuanbing commented Oct 22, 2024

What problem does this PR solve?

  1. feat: split ragflow into three components(ragflow-web, ragflow-api, ragflow-worker)

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

chongchuanbing added 3 commits October 22, 2024 14:26
(cherry picked from commit 534ec47e82bde01ce5a6db2763a71aee84b04b0c)
(cherry picked from commit b8f20142774ae4c29655957db4cd8ce84c0c29bf)
@KevinHuSh
Copy link
Collaborator

Appreciate your contribution.

Feature 2 involves a scope that is too broad and makes changes to the entire framework, so it will not be adopted for the time being.

@yuzhichang
Copy link
Member

@chongchuanbing Please split feature 2 into another PR. I'm considering replacing nginx with uvicorn, or even converting the codebase to async style.

@chongchuanbing
Copy link
Contributor Author

@chongchuanbing Please split feature 2 into another PR. I'm considering replacing nginx with uvicorn, or even converting the codebase to async style.

I have removed the bug fix, now only feature 2.

@yuzhichang
Copy link
Member

yuzhichang commented Oct 23, 2024

@chongchuanbing I would suggest:

  • Remove Nginix entirely. We don't want to maintain such complex configuration. You could split that into another repo.
  • Merge ragflow-web and ragflow-api into one. An single flask serves API and static pages.
  • Introduce Gunicorn so that ragflow-server runs in thread-pool.
  • Research replacing Flask with Quart, the async variant of Flask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants