Skip to content

Commit

Permalink
code style improved
Browse files Browse the repository at this point in the history
  • Loading branch information
infinite-system committed Feb 26, 2023
1 parent 5e56768 commit e9e2523
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
1 change: 0 additions & 1 deletion x/Octopus/Concerns/TagSetupModels.php
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ public function getModelTable() {
return $this->modelModel->getTable();
}


/**
* Qualify which model we are connecting to as target.
*
Expand Down
3 changes: 0 additions & 3 deletions x/Octopus/Tag.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use Illuminate\Database\Eloquent\Relations\HasManyThrough;
use Illuminate\Database\Eloquent\Relations\HasOneThrough;


class Tag
{
use Concerns\TagSetupModels;
Expand Down Expand Up @@ -177,7 +176,6 @@ class Tag
*/
protected string $targetClass;


/**
* Through type id.
*
Expand Down Expand Up @@ -264,7 +262,6 @@ public function __construct(

}


/**
* Return built relation.
*
Expand Down
12 changes: 5 additions & 7 deletions x/Octopus/TagThrough.php
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ class TagThrough
*/
protected string $hasRelation;


/**
* Eloquent built in has relation class name.
*
Expand Down Expand Up @@ -185,7 +184,6 @@ class TagThrough
*/
protected int $categoryThroughType;


/**
* Connect key depends on inverse param.
*
Expand Down Expand Up @@ -303,7 +301,6 @@ public function __construct(
$this->resetTargetTable();
}


/**
* Build tag through relationship.
*
Expand Down Expand Up @@ -436,7 +433,6 @@ protected function buildSelect() {
);
}


/**
* Build inverse relationship.
*
Expand All @@ -451,7 +447,6 @@ protected function buildTagThroughInverse() {
$this->buildSelectInverse();
}


/**
* Join to target model inverse.
*
Expand Down Expand Up @@ -506,7 +501,6 @@ protected function whereRelationInverse() {

}


/**
* Build select statement for the inverse relationship.
*
Expand All @@ -533,6 +527,11 @@ protected function buildSelectInverse() {
));
}

/**
* Table alias exists.
*
* @return bool
*/
protected function hasTableAlias() {
return $this->tableAlias !== null;
}
Expand Down Expand Up @@ -564,7 +563,6 @@ protected function hasTarget() {
return $this->target !== null;
}


/**
* Handle soft deletes if they are enabled in target model.
*
Expand Down

0 comments on commit e9e2523

Please sign in to comment.