Remove MOI as Explicit Dependency #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 32 32
Lines 6286 6286
=======================================
Hits 6284 6284
Misses 2 2
Continue to review full report at Codecov.
|
odow
reviewed
Aug 3, 2021
odow
reviewed
Aug 3, 2021
| @@ -2,8 +2,7 @@ module TranscriptionOpt | |||
|
|
|||
| # Import the necessary packages. | |||
| import JuMP | |||
| import MathOptInterface | |||
| const MOI = MathOptInterface | |||
| const MOI = JuMP.MOI | |||
There was a problem hiding this comment.
It's surprising that MOI doesn't get pulled in by using JuMP. Anyway, this seems to work.
There was a problem hiding this comment.
Here I just use import JuMP which I wouldn't think pulls in any of its exported objects. However, I realized this is redundant this using ..InfiniteOpt used below it pulls in JuMP and its exports anyway. #158 removes this redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to see if we can remove MOI.
EDIT:
It appears that we can since
Reexportexports theMOIalias defined inJuMP.