Fix Generality of sum and prod
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 99.81% 99.77% -0.05%
==========================================
Files 33 33
Lines 7073 7082 +9
==========================================
+ Hits 7060 7066 +6
- Misses 13 16 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
This works, but it is getting erroneous coverage misses and I am not sure why two of the links in the docs are getting 403 errors (this has nothing to do with this pull request). |
|
It works, thank you for addressing the problem so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260.
@FedeClaudi, I think this should fix your problems. Can you please check it with your use case. You can checkout this branch via:
If it works, then I will merge this and release a new version of InfiniteOpt.