-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize JuMP README #312
Finalize JuMP README #312
Conversation
Let's wait for the preview. It's easy to miss things just looking at Markdown. |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 36 36
Lines 7099 7099
=======================================
Hits 7083 7083
Misses 16 16 |
The linter failed. Here are the errors:
|
Here's the preview: https://jump.dev/JuMP.jl/previews/PR3343/packages/InfiniteOpt/ |
Ok, the latest commit should fix the linter problems |
Started a new doc build off |
I think we're safe to skip a doc rebuild with that last commit 😄 |
You could also change the opening sentence to
|
@odow: anything else before I merge this? |
This addresses the concerns of @odow raised in #311.
@odow: Any other concerns or suggestions?