Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorTuple Addition and Improved Measure Expansion #48

Merged
merged 7 commits into from
Apr 8, 2020

Conversation

pulsipher
Copy link
Collaborator

@pulsipher pulsipher commented Apr 8, 2020

Summary
The use of tuples for infinite variables and point variables has been replaced with VectorTuples. Also, measure data has been improved to use more efficient storage types and several getter functions have been added. Measure expansion was completely rewritten to make it more extendable, simple, and efficient.

This PR fixes/implements the following bugs/features

  • Correctly handles and stores partial reduction of a multi-dimensional tuple elements
  • Fixes minor bugs throughout
  • VectorTuple is now a fully enabled container type
  • Added measure getter functions and made datatypes better
  • Measure expansion is now much more efficient and intuitive
  • Formatting for multi-dimensional measure data and point support is a little more picky now
  • Transcribe now doesn't preserve parameter indices --> needs to be rewritten

Closing issues

Mostly Fixes #45

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #48 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   99.74%   99.78%   +0.04%     
==========================================
  Files          25       28       +3     
  Lines        3132     3272     +140     
==========================================
+ Hits         3124     3265     +141     
+ Misses          8        7       -1     
Impacted Files Coverage Δ
src/InfiniteOpt.jl 100.00% <ø> (ø)
src/TranscriptionOpt/TranscriptionOpt.jl 100.00% <ø> (ø)
src/TranscriptionOpt/model.jl 100.00% <ø> (ø)
src/Collections/Collections.jl 100.00% <100.00%> (ø)
src/Collections/VectorTuple.jl 100.00% <100.00%> (ø)
src/MeasureEvalMethods/methods.jl 100.00% <100.00%> (+1.96%) ⬆️
src/TranscriptionOpt/measures.jl 100.00% <100.00%> (ø)
src/TranscriptionOpt/transcribe.jl 99.42% <100.00%> (-0.01%) ⬇️
src/constraints.jl 100.00% <100.00%> (ø)
src/datatypes.jl 97.91% <100.00%> (-2.09%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9125d...57ea90e. Read the comment docs.

@pulsipher pulsipher merged commit 3adbb27 into master Apr 8, 2020
@pulsipher pulsipher deleted the parameter-ref-management branch April 8, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Reduced Infinite Variables
1 participant