Add controls for AILabImage component stories - Half-Fix #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
commented
Dec 22, 2021
| // justBoxes, | ||
| // justValues, | ||
| // ]); | ||
| tf.dispose([ |
There was a problem hiding this comment.
I'm not sure why this dispose was commented out, but it needs to be brought back in to protect from mem-leaks
There was a problem hiding this comment.
You are right! I was getting type errors and since fast refresh disposed tensors I commented those out then forgot to brought them back even after the type errors are fixed in different components.
kateinkim
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds controls to Image story - also required fixes that close #34 and tie into completing #33.
This also identified the bug #35