-
Notifications
You must be signed in to change notification settings - Fork 150
Conversation
Thanks for the PR @lvlrSajjad. Semaphoreci has some complaints:
Could you fix those please? |
yes taken care of but it says
while it generates correctly |
in semaphore log it seems we getting errors like these
i think the semaphor's yarn/npm version is in incompatible with react-native@0.57.5. in my system i can run this test at least the first one successfully passes . |
by its installation guid https://reactnavigation.org/docs/en/getting-started.html we need to add something to MyActivity class in android , not needed in ios. so i patched file in boilerplate.js
@lvlrSajjad we're removing Semaphore from this project and adding Circle CI instead. We can ignore the Semaphore failure and see whether it passes on Circle once it's ready. |
i just accidently closed the pull |
@lvlrSajjad yes, you'll need the circle config, but it looks like you got it already. |
well it seems it can't find lint command in package.json of installed project . maybe it can't run ignite add standard |
Yep. I'm currently trying to figure out why. It's able to do it on the master branch, so I'm kind of stumped. |
i found problem it's something wrong with my react-navigation linking , i will cover it :-D @mlaco |
Congrats, it worked! |
Let me just look over the code again before I merge (I want to get a second review too) |
@mlaco Test passed but i need to find the problem with patch in file :-D cause i need to do that modifications on mainactivity.java as this link says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked our team for a second review, too
boilerplate.js
Outdated
import com.facebook.react.ReactRootView; | ||
import com.swmansion.gesturehandler.react.RNGestureHandlerEnabledRootView;` | ||
}) | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this commented out section be left in without an explanation of why it's commented out in favor of the code block above it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now i'm just commenting / uncommenting stuff till i findout what is wrong i'll say when i'm done
@@ -197,7 +219,7 @@ async function install (context) { | |||
} | |||
|
|||
if (answers['redux-persist'] === 'Yes') { | |||
await system.spawn(`ignite add redux-persist@"~>1.0.1" ${debugFlag}`, { | |||
await system.spawn(`ignite add redux-persist@"~>5.10.0" ${debugFlag}`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOLY CRAP that's a massive version upgrade!
Guys I'm done |
@lvlrSajjad yes, thank you! I appreciate your hard work and dedication. |
# [2.4.0](v2.3.1...v2.4.0) (2018-12-01) ### Bug Fixes * **ci:** Testing CI release ([ef979cc](ef979cc)) * **ci:** Testing CI release ([83e6a3d](83e6a3d)) * **ci:** Testing CI release ([4ff0748](4ff0748)) ### Features * **react-native:** upgraded default react-native version ([#228](#228)) ([575d24c](575d24c))
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
upgraded default react-native version to 0.57.7
updated react-navigation to 3.0.0
also updated ignite-dev-screens,redux,redux-persist and some other libs to the last version
after changes i got it running in android and it was ok
removed allowFontScaling from
boilerplate/App/Config/index.js
cause it causes error in new react-native version