Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fix hot reloading on storybook #34

Merged
merged 3 commits into from
Jun 5, 2018
Merged

Fix hot reloading on storybook #34

merged 3 commits into from
Jun 5, 2018

Conversation

leonskim
Copy link
Member

@leonskim leonskim commented Jun 5, 2018

@leonskim leonskim requested a review from skellock June 5, 2018 11:44
@leonskim leonskim changed the title (WIP) Fix hot reloading on storybook Fix hot reloading on storybook Jun 5, 2018
Copy link
Contributor

@skellock skellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are amazing!

I spent about 30 minutes on this and couldn't figure it out.

I don't think that @types/node should be included. You probably did that for module ya?

What do you say we remove that and add this to main.tsx:

// appease the storybook overlords
declare global {
  var module
}

That's us declaring that module exists on the global scope, but doesn't bring in the whole API of node.js into our react native app.

@skellock skellock merged commit 522d2b9 into master Jun 5, 2018
@skellock skellock deleted the storybook-hot-reloading branch June 5, 2018 17:44
@leonskim
Copy link
Member Author

leonskim commented Jun 5, 2018

@skellock Ah, good to know!
@kevinvangelder Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants