Add base styles file and refactor styles in boilerplate app #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpena
changed the title
mazenchami
approved these changes
Jul 30, 2024
frankcalise
approved these changes
Jul 30, 2024
Comment on lines
+8
to
+11
| container: { | ||
| paddingTop: spacing.lg + spacing.xl, | ||
| paddingHorizontal: spacing.lg, | ||
| } as ViewStyle, |
There was a problem hiding this comment.
These look to only appear on the demo app screens. We should wrap a comment block around here for removing this block since it'll be unused if/when the user removes the demo code.
You can test the difference with --remove-demo (or the Y flag when it asks if you want to remove the demo app) and see that it gets removed or remains accordingly.
Suggested change
| container: { | |
| paddingTop: spacing.lg + spacing.xl, | |
| paddingHorizontal: spacing.lg, | |
| } as ViewStyle, | |
| // @demo remove-block-start | |
| container: { | |
| paddingTop: spacing.lg + spacing.xl, | |
| paddingHorizontal: spacing.lg, | |
| } as ViewStyle, | |
| // @demo remove-block-end |
There was a problem hiding this comment.
@fpena be sure to also add this file to the remove file: test/vanilla/__snapshots__/ignite-remove-demo.test.ts.snap
|
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
This PR:
boilerplate/app/theme/styles.ts