-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2754] Swap out i18n-js for react-18next #2770
Conversation
ce168a0
to
9f1f9a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
What was the motivation behind the screen:some.key
naming scheme change?
Not opposed to it, just made a bunch of extra changes because of it.
@frankcalise it is the namespace separator for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
🎉 This PR is included in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantyarn lint
eslint checks pass with new code, if relevantyarn format:check
prettier checks pass with new code, if relevantREADME.md
(or relevant documentation) has been updated with your changesDescribe your PR
This PR replaces the
i18n-js
library withi18next
to enhance internationalization in the project. The migration ensures better support for translations, including improved handling of locale-specific formats, pluralization, and more efficient loading of translation resources.Key Changes:
Note: We will also create a cookbook recipe later that references this PR for Ignite users who want to migrate from
i18n-js
toi18next
and are using Ignite 9.x or less.Video
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-12.at.13.44.15.mp4