Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boilerplate): expo-router keyboard provider + theme fix #2825

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented Oct 24, 2024

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

  • In this community slack thread it was brought up that the KeyboardProvider was omitted from the expo-router template
  • This PR fixes that and also aligns the expo-router layout file to be consistent with the app navigator from the main template
  • This also restyles the Welcome screen properly so the theming system works out of the box in the expo-router template

@frankcalise frankcalise merged commit f82f324 into master Oct 29, 2024
1 check passed
@frankcalise frankcalise deleted the fix/expo-router-providers branch October 29, 2024 21:54
infinitered-circleci pushed a commit that referenced this pull request Oct 29, 2024
## [10.0.2](v10.0.1...v10.0.2) (2024-10-29)

### Bug Fixes

* **boilerplate:** expo-router keyboard provider + theme fix ([#2825](#2825) by [@frankcalise](https://github.com/frankcalise)) ([f82f324](f82f324))
* **cli:** add --legacy-peer-deps for npm users ([#2823](#2823) by [@frankcalise](https://github.com/frankcalise)) ([e59d880](e59d880))
* **cli:** fix issue with workflow prompt values ([#2821](#2821) by [@frankcalise](https://github.com/frankcalise)) ([f2cdd00](f2cdd00))
* **cli:** replace shell commands with filesystem API ([#2817](#2817) by @AsterisMono) ([fd0a418](fd0a418))
@infinitered-circleci
Copy link

🎉 This PR is included in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JuanJo4
Copy link

JuanJo4 commented Nov 9, 2024

Thanks for this @frankcalise ! I just catch this bug in 10.0.1 while playing around with expo router.

Is there any work done or planned to replicate the demo screens using expo-router? i'm doing that just to learn, i might be able to help with that if that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants