Add README note to avoid issues with parked domains #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unconfigured (parked) Porkbun domains have trouble using dns-porkbun. By default, Porkbun does not enable API access on domains, and two default ALIAS records pointing to Porkbun's domains make dns-porkbun do a CNAME forwarded verification with Porkbun's domain. The latter issue is particularly bad because the only error given is an
Invalid domain.error, which more-or-less leaves you to intuit that your domain redirected verification to another. I would consider adding a log message to more clearly indicate the result of domain resolutions, though I digress.These issues should only appear on parked Porkbun domains. The software is behaving exactly as it should, but some people (myself included) may try to generate certificates before setting up their DNS records, potentially causing them issues. To remedy this, I'm opening this PR with a note advising users to enable API access and remove the default ALIAS records.
Thanks!