Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding frontend libs private options #372

Merged
merged 1 commit into from
Aug 30, 2023
Merged

adding frontend libs private options #372

merged 1 commit into from
Aug 30, 2023

Conversation

iruzevic
Copy link
Member

Description

  • added new option to find blocks in the eightshift-frontend-libs-private repo also

@iruzevic iruzevic requested a review from a team August 30, 2023 07:15
@iruzevic iruzevic self-assigned this Aug 30, 2023
@kancijan kancijan self-requested a review August 30, 2023 07:20
@iruzevic iruzevic merged commit e862e2e into develop Aug 30, 2023
5 of 7 checks passed
@iruzevic iruzevic deleted the feature/libs-private branch August 30, 2023 08:42
@dingo-d
Copy link
Collaborator

dingo-d commented Sep 22, 2023

You merged this feature and broke over 90 tests

https://github.com/infinum/eightshift-libs/actions/runs/6021762970/job/16335221092?pr=372

That's not good 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kancijan kancijan kancijan approved these changes

@iobrado iobrado iobrado approved these changes

Assignees

@iruzevic iruzevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iruzevic @dingo-d @iobrado @kancijan