Fix race conditions with functions returning "no output" #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the commit getditto@b191ff4 is based off the crates.io release (to reduce the churn from 1 The fix can be tested using…[patch.crates-io.node-bindgen]
version = "3.0.0"
git = "https://github.com/getditto/node-bindgen"
rev = "b191ff4d671418ee56cc99b75acfd1853cdab6e6" |
The current implementation of `#[node_bindgen]` wrapping shim over `async fn` functions special cased those with no return value to return immediately, for some reason. This meant that if such an `async fn` had a side-effect that following-up code wanted to observe, there would be a race condition whereby such code could observe causally-inconsitent state, leading to logic bugs.
danielhenrymantilla
force-pushed
the
dhm/fix-async-fn-no-output
branch
from
b191ff4
to
038c012
Compare
sehz
requested changes
Nov 19, 2020
nickbabcock
added a commit
to nickbabcock/node-bindgen
that referenced
this pull request
Nov 19, 2020
This commit adds the test case component to infinyon#102 to ensure that this behavior is not regressed on.
sehz
pushed a commit
that referenced
this pull request
Nov 20, 2020
This commit adds the test case component to #102 to ensure that this behavior is not regressed on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
#[node_bindgen]wrapping shim overasync fnfunctions special cased those with no return value to return immediately. This meant that if such anasync fnhad a side-effect that following-up code wanted to observe, there would be a race condition whereby such code could observe causally-inconsistent state, leading to logic bugs.Removing that special-cased branch seems to have fixed the issue.