-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove global initialization of logger #174
Conversation
Hi @marcmo, thanks for the PR! We're hoping to test this out and give some feedback soon 👍 |
@nicholastmosher is this still something you consider? Then I would add some documentation for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for lates response. I think there is forward step to resolving this issue
- fixes infinyon#134 - Provide macro to run code on initialization without introducing additional direct dependencies to client projects. - without this global initialization applications need to setup their own logging infrastructure at startup - Adapted logger example with the use of a custom logger
ec10628
to
03643a8
Compare
@sehz I created a separate example to demonstrate the custom logger. |
By default (if custom init is not called), we need to initialize logger. Otherwise, everyone need to initialize logger explicitly. I can take look see if there is way to insert global logger if not initialized |
IMHO initialization of a logging framework is something every application should do individually. At least, that's how almost all libraries/frameworks I know do it. |
Hmm. I think you have valid point. This is meant to to be used in any library/application. Default initializing maybe too opinionated and also may be more complexity than warranted. In that case, this PR seems to be good stage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this thru
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will bump up version change after this goes thru
bors r+ |
- fixes #134 - Provide macro to run code on initialization without introducing additional direct dependencies to client projects. - without this global initialization applications need to setup their own logging infrastructure at startup - Adapted function example with the use of a custom logger
Pull request successfully merged into master. Build succeeded: |
additional direct dependencies to client projects.
own logging infrastructure at startup