Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashes in schema names with PostgresqlSchemaAdapter #198

Closed
jonsgreen opened this issue Jan 8, 2015 · 2 comments
Closed

Dashes in schema names with PostgresqlSchemaAdapter #198

jonsgreen opened this issue Jan 8, 2015 · 2 comments

Comments

@jonsgreen
Copy link
Contributor

I just discovered that the pg_dump fails for new schemas with dashes when calling Apartment::Tenant.create with use_sql because the schema name is not being wrapped in double quotes. I will be submitting a simple fix with spec as a pull request shortly.
jonsgreen pushed a commit to jonsgreen/apartment that referenced this issue Jan 8, 2015
Dashes in schema names with PostgresqlSchemaAdapter influitive#198
62a6d65 
see: influitive#198
@jonsgreen jonsgreen mentioned this issue Jan 8, 2015
Merged
jonsgreen pushed a commit to jonsgreen/apartment that referenced this issue Jan 8, 2015
BugFix: Dashes in schema names with PostgresqlSchemaAdapter influitiv…
a5f4553 
…e#198

see: influitive#198
bradrobertson added a commit that referenced this issue Jan 9, 2015
@bradrobertson
Merge pull request #199 from jonsgreen/bugfix/postgres-sql-schema-wit…
470b651 
…h-dashes

 Dashes in schema names with PostgresqlSchemaAdapter #198
@jonsgreen
Copy link
Contributor Author

Thank you for merging the pull request. Just curious if you have a sense of when this might be released into a future gem version?

@bradrobertson
Copy link
Contributor

I'll do a patch release for this. We'll have a 1.0 out shortly with the new interface.

merchantaccountscreditcards8 added a commit to merchantaccountscreditcards8/apartment that referenced this issue Aug 17, 2024
@merchantaccountscreditcards8
BugFix: Dashes in schema names with PostgresqlSchemaAdapter #198
b3c84f2 
see: influitive/apartment#198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonsgreen @bradrobertson