Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: libflux build error on >= rust-1.72.0 #5440

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

stkw0
Copy link
Contributor

@stkw0 stkw0 commented Nov 9, 2023

Closes: #5438

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

This a trivial patch to fix an issue with rust-1.72.0 (see linked issue).

@crepererum
Copy link

@stkw0 sorry for the late reply, could you please fix the commit message to follow our semantic commit style: fix: libflux build .... (basically just put a colon behind fix).

@crepererum crepererum changed the title fix libflux build error on >= rust-1.72.0 fix: libflux build error on >= rust-1.72.0 Nov 15, 2023
@crepererum crepererum merged commit 8d1d6c8 into influxdata:master Nov 15, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.194.{3,4} failed to build against rust 1.72.0
2 participants