Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing explicit lifetime for rust 1.83 build #5516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Nov 30, 2024

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.


👋 This PR is fixing the regression build issue against rust 1.83.0:

  error: elided lifetime has a name
     --> flux-core/src/ast/walk/mod.rs:183:47
      |
  181 | impl<'a> Node<'a> {
      |      -- lifetime `'a` declared here
  182 |     #[allow(missing_docs)]
  183 |     pub fn from_expr(expr: &'a Expression) -> Node {
      |                                               ^^^^ this elided lifetime gets resolved as `'a`
      |
  note: the lint level is defined here
     --> flux-core/src/lib.rs:1:38
      |
  1   | #![cfg_attr(feature = "strict", deny(warnings, missing_docs))]
      |                                      ^^^^^^^^
      = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`
  
  error: elided lifetime has a name
    --> flux-core/src/parser/mod.rs:44:37
     |
  42 | impl<'input> Parser<'input> {
     |      ------ lifetime `'input` declared here
  43 |     /// Instantiates a new parser with the given string as input.
  44 |     pub fn new(src: &'input str) -> Parser {
     |                                     ^^^^^^ this elided lifetime gets resolved as `'input`

Signed-off-by: Rui Chen <rui@chenrui.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.195.2 failed to build against rust 1.83.0
1 participant