Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up project skeleton for new CLI #1

Merged
merged 13 commits into from
Apr 12, 2021
Merged

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Apr 12, 2021

Closes #2

  • Set up go modules, using Go 1.16
  • Add the entry-point for the CLI, with the version command implemented
  • Add our standard linting tools/scripts
  • Add a Makefile to be the source-of-truth for build/test/lint commands
  • Add a basic CircleCI workflow

jobs:
- lint
- build
- test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we might want a pre-step to cache dependencies. If we hit that point, we'll need to deal with golang/go#43994

"os"
"time"

"github.com/urfave/cli/v2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risking an innovation token on urfave/cli over spf13/cobra. cobra has always felt more heavyweight/verbose to me than a CLI parser needs to be. cli looks very similar to the kit/cli convenience wrapper in influxdb.

If we hit a wall with it, we can fall back to using cobra and copy the code from influxdb.

@danxmoran danxmoran merged commit 8c062ca into main Apr 12, 2021
@danxmoran danxmoran deleted the dm-initial-setup branch April 12, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap the project
2 participants