fix: compatible with latest dart version #151
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 21.00% 21.00%
=======================================
Files 117 117
Lines 7552 7551 -1
=======================================
Hits 1586 1586
+ Misses 5966 5965 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…ng libraries versions => different dart version in CI can't have different version of deps
bednar
changed the title
intl package is not required, the API doesn't require _dateFormatter
bednar
changed the title
.gitignore
Outdated
| @@ -6,7 +6,7 @@ | |||
| .packages | |||
| build/ | |||
| # If you're building an application, you may want to check-in your pubspec.lock | |||
There was a problem hiding this comment.
So if pubspec.lock is being ignored, does this comment still make sense? My understanding is that pubspec.lock gets generated locally based on pubspec.yaml and that not every generated pubspec.lock will be universally portable.
There was a problem hiding this comment.
You are right I will remove this comment.
Closes #148
Closes #149
Closes #150
Proposed Changes
intlas a required dependency — theintlpackage was used in the OpenApi generator, but our code does not utilize it.pubspec.lockis not part of the repository because it determines library versions; thus, different Dart versions in CI may require different versions of dependencies.dependabotis no longer in beta status.Checklist
pub run testcompletes successfully