Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryInterval option default does not match documentation? #108

Closed
Tomcat-Engineering opened this issue Apr 30, 2020 · 1 comment · Fixed by #114
Closed

RetryInterval option default does not match documentation? #108

Tomcat-Engineering opened this issue Apr 30, 2020 · 1 comment · Fixed by #114
Assignees
@vlastahajek
Milestone
v1.2.0

Comments

@Tomcat-Engineering
Copy link

The comment for the retry interval field of the Options struct says:

Default retry interval in ms, if not sent by server. Default 30s

However, the code in the DefaultOptions function says retryInterval: 1000, which would only be one second.

Shouldn't they match?
@vlastahajek vlastahajek self-assigned this Apr 30, 2020
@vlastahajek vlastahajek added this to the v1.2.0 milestone Apr 30, 2020
@vlastahajek
Copy link
Contributor

@Tomcat-Engineering, thanks for the issue. Default value 1s is correct, we will fix the comment.

@vlastahajek vlastahajek mentioned this issue May 5, 2020
Closed
4 tasks
vlastahajek added a commit to bonitoo-io/influxdb-client-go that referenced this issue May 5, 2020
@vlastahajek
fix: Fixing comment for retry interval (influxdata#108)
cf892ad
@vlastahajek vlastahajek mentioned this issue May 5, 2020
Merged
4 tasks
vlastahajek added a commit that referenced this issue May 5, 2020
@vlastahajek
Merge pull request #114 from bonitoo-io/fix/docs-default-retry-interv…
8e00135 
…al-#108

fix: Fixing comment for retry interval (#108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlastahajek vlastahajek

Labels
None yet
Projects
None yet
Milestone
v1.2.0
2 participants
@Tomcat-Engineering @vlastahajek