feat: allow overriding the http.Client for the http service #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 82.01% 82.09% +0.07%
==========================================
Files 32 32
Lines 2035 2044 +9
==========================================
+ Hits 1669 1678 +9
Misses 247 247
Partials 119 119
Continue to review full report at Codecov.
|
vlastahajek
reviewed
Jul 28, 2020
jsternberg
force-pushed
the
set-http-client
branch
from
126997f
to
e8f0a1d
Compare
vlastahajek
requested changes
Jul 28, 2020
jsternberg
force-pushed
the
set-http-client
branch
from
e8f0a1d
to
2fb1c66
Compare
This allows overriding the http.Client for the http service. If the client is overridden, the other options are ignored. This allows further customization such as modifying the underlying http.Transport or the `CheckRedirect` function.
jsternberg
force-pushed
the
set-http-client
branch
from
2fb1c66
to
2028a4e
Compare
vlastahajek
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows overriding the http.Client for the http service. If the
client is overridden, the other options are ignored. This allows further
customization such as modifying the underlying http.Transport or the
CheckRedirectfunction.