fix: WriteAPIs management #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
I accept the fact that the pool of two Write APIs is maintained by the client to avoid backward compatibility issues. An alternative, that would require users to close the Write APIs, is not considered in favor of BC. Please also consider to use a different separator than _ as a pool key that separates org and bucket to minimize possible collisions, a TAB might work better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163
Proposed Changes
Keeping a single instance of WriteAPI and WriteAPIBlocking for each org and bucket pair.
Checklist