Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boolDatatype not match line protocol #191

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

PeerXu
Copy link
Contributor

@PeerXu PeerXu commented Aug 18, 2020

Proposed Changes

fix bug: failed to parse boolean datatype in QueryTableResult.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files          27       27           
  Lines        1860     1860           
=======================================
  Hits         1667     1667           
  Misses        138      138           
  Partials       55       55           
Impacted Files Coverage Δ
api/query.go 88.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0733660...0ab3efe. Read the comment docs.

@vlastahajek vlastahajek self-requested a review August 18, 2020 13:00
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeerXu, Thanks for the fix! Add also changelog entry, please.

@PeerXu
Copy link
Contributor Author

PeerXu commented Aug 18, 2020

@vlastahajek add something to changelog.

CHANGELOG.md Outdated
@@ -1,4 +1,7 @@
## 2.1.0 [in progress]
### Bug fixes
1. [#190](https://github.com/influxdata/influxdb-client-go/issues/190) Fixed QueryTableResult.Next() failed to parse boolean datatype.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a link to PR, not to issue..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to parse result with boolean value
3 participants