Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Client.Close() also closes idle connections #192

Merged
merged 3 commits into from
Aug 19, 2020
Merged

fix: Client.Close() also closes idle connections #192

merged 3 commits into from
Aug 19, 2020

Conversation

vlastahajek
Copy link
Contributor

@vlastahajek vlastahajek commented Aug 18, 2020 •
edited by sranka
Loading

Closes #183

Proposed Changes

Client.Close() also closes idle connections if the HTTP client was created internally (#183)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

sranka
sranka approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor proof-reading change

CHANGELOG.md Outdated Show resolved Hide resolved
@vlastahajek @sranka
docs(changelog): rewording fix description
6f67912 
Co-authored-by: Pavel Závora <pavel.zavora@bonitoo.io>
@vlastahajek vlastahajek merged commit a87b829 into influxdata:master Aug 19, 2020
@vlastahajek vlastahajek deleted the fix/close_iddle_connections branch August 19, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client is leaking TCP connections
2 participants
@vlastahajek @sranka