Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: example and API docs improvements #242

Merged
merged 3 commits into from
Apr 15, 2021
Merged

docs: example and API docs improvements #242

merged 3 commits into from
Apr 15, 2021

Conversation

vlastahajek
Copy link
Contributor

Proposed Changes

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Commit messages are in semantic format

@vlastahajek vlastahajek requested a review from sranka April 9, 2021 13:09
@vlastahajek vlastahajek marked this pull request as draft April 12, 2021 07:07
@vlastahajek vlastahajek marked this pull request as ready for review April 15, 2021 11:41
sranka
sranka approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@sranka sranka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suggest a few small documentation improvements.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
api/write.go Outdated Show resolved Hide resolved
api/writeAPIBlocking.go Outdated Show resolved Hide resolved
@vlastahajek @sranka
chore: apply suggestions from code review
035fe56 
Co-authored-by: Pavel Závora <pavel.zavora@bonitoo.io>
@vlastahajek vlastahajek merged commit 39e956c into influxdata:master Apr 15, 2021
@vlastahajek vlastahajek deleted the doc/example_cont branch April 15, 2021 12:04
@vlastahajek vlastahajek added this to the v2.3.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sranka sranka sranka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vlastahajek @sranka