fix: add concurrency panic protection around Client and WriteAPIImpl Close #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleonard203
changed the title
dleonard203
commented
Mar 26, 2022
| @@ -194,6 +197,8 @@ x: | |||
| // Close finishes outstanding write operations, | |||
| // stop background routines and closes all channels | |||
| func (w *WriteAPIImpl) Close() { | |||
| w.closingMu.Lock() | |||
There was a problem hiding this comment.
Since this is an exported type, users could (and may already) call WriteAPIImpl{} without instantiating this new mutex, so it could default to nil. Does doing a nil check make sense here before acquiring the lock?
There was a problem hiding this comment.
As there is no nil check for other fields, it is not necessary.
vlastahajek
changed the title
vlastahajek
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR aims to address #317 . If multiple goroutines call
influxdb2.Client.Close(), orapi.WriteAPI.Close(), it is possible for there to be a panic due to closing a closed channel.Closes #317
Checklist