Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): doclint for JDK 18 #406

Merged
merged 4 commits into from
Sep 1, 2022
Merged

fix(docs): doclint for JDK 18 #406

merged 4 commits into from
Sep 1, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Aug 29, 2022 •
edited
Loading

Closes #405

Proposed Changes

  1. Fixed compatibility of the doclint between JDK 8 and JDK 18
  2. Enabled generating javadoc in CI

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek August 29, 2022 13:36
@bednar bednar marked this pull request as ready for review August 29, 2022 13:36
@bednar bednar added bug Something isn't working documentation Documentation change labels Aug 29, 2022
@rhajek
Copy link
Contributor

rhajek commented Aug 31, 2022

Tested on apple silicon, openjdk version "17.0.4" 2022-07-19 LTS, mvn -DskipTests clean package new javadocs looks 👍

@bednar bednar merged commit 631133e into master Sep 1, 2022
@bednar bednar deleted the javadoc-compatibility branch September 1, 2022 04:45
@bednar bednar added this to the 6.6.0 milestone Sep 1, 2022
@powersj
Copy link
Contributor

powersj commented Sep 2, 2022

@bednar thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Documentation change
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.

mvn package on Java 18 fails building javadoc
3 participants
@bednar @rhajek @powersj