Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential NPE of WriteParameters#hashCode #483

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Dec 13, 2022

Closes #482

Proposed Changes

Fixed potential NPE for WriteParameters#hashCode.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review December 13, 2022 09:50
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Vlasta Hajek <vlastimil.hajek@bonitoo.io>
@codecov-commenter
Copy link

Codecov Report

Base: 88.38% // Head: 88.42% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (36ae228) compared to base (9b07e6e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #483      +/-   ##
============================================
+ Coverage     88.38%   88.42%   +0.04%     
- Complexity      764      777      +13     
============================================
  Files           172      172              
  Lines          7008     7008              
  Branches        378      380       +2     
============================================
+ Hits           6194     6197       +3     
+ Misses          694      692       -2     
+ Partials        120      119       -1     
Impacted Files Coverage Δ
...ava/com/influxdb/client/write/WriteParameters.java 83.92% <100.00%> (+3.57%) ⬆️
...a/com/influxdb/client/internal/BucketsApiImpl.java 71.16% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar merged commit 00f4f81 into master Dec 13, 2022
@bednar bednar deleted the writeparameters-npe branch December 13, 2022 21:04
@bednar bednar changed the title fix: potential NPE for WriteParameters#hashCode fix: potential NPE of WriteParameters#hashCode Dec 13, 2022
@bednar bednar added this to the 6.8.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WriteParameters#hashCode can produce NPE
3 participants