Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InfluxQL tags support #584

Merged
merged 4 commits into from
Jun 22, 2023
Merged

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jun 21, 2023

Closes #534

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 68.42% and project coverage change: -0.05 ⚠️

Comparison is base (1640d60) 88.41% compared to head (3c340c0) 88.36%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #584      +/-   ##
============================================
- Coverage     88.41%   88.36%   -0.05%     
+ Complexity      779      777       -2     
============================================
  Files           172      172              
  Lines          7008     7022      +14     
  Branches        380      382       +2     
============================================
+ Hits           6196     6205       +9     
- Misses          693      698       +5     
  Partials        119      119              
Impacted Files Coverage Δ
...n/java/com/influxdb/query/InfluxQLQueryResult.java 0.00% <0.00%> (ø)
...influxdb/client/internal/InfluxQLQueryApiImpl.java 90.78% <100.00%> (+1.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alespour alespour marked this pull request as ready for review June 21, 2023 13:43
@alespour alespour requested a review from bednar June 21, 2023 13:43
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍, there is one small requirement:

@alespour alespour requested a review from bednar June 22, 2023 08:33
@alespour alespour merged commit a95ec06 into master Jun 22, 2023
@alespour alespour deleted the feat/influxql-tags-support branch June 22, 2023 09:03
@bednar bednar added this to the 6.10.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getInfluxQLQueryApi.query() Execution results "InfluxQLQueryResult" Why is there no tag column ?
3 participants