-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for Pekko Streams in the scala client #661
Conversation
8add77f
to
aa73428
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #661 +/- ##
============================================
+ Coverage 88.35% 88.37% +0.01%
Complexity 777 777
============================================
Files 173 173
Lines 7078 7078
Branches 393 393
============================================
+ Hits 6254 6255 +1
+ Misses 699 698 -1
Partials 125 125 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @utkuaydn,
I want to express my sincere gratitude for your pull request. It's a substantial improvement to our client, and we truly appreciate the effort and expertise you've brought into this project. Given Lightbend's decision to license future Akka releases under the Business Software License — which is incompatible with Open Source usage — I agree with your perspective that use Pekko streams.
From our point of view the Akka Streams should be replaced by Pekko Streams.
Could you please update your pull request to reflect these changes?
- Remove Akka Streams: Completely transition away from Akka Streams and implement Pekko streams throughout the client.
- Upgrade Major Version: Update the major version of the client to 7.0.0 to reflect this significant change and its potential impacts on compatibility.
These updates will align our client with a fully open-source framework and ensure its usability and compliance with open-source licensing moving forward.
Once again, thank you for your contribution, and we look forward to seeing the updated pull request.
f11bf0e
to
aeea943
Compare
Hi @bednar It is my pleasure to be able to contribute. I have removed everything Akka-related per your request. The only edit on your part would have to be the date on the changelog since I do not know when you will be releasing this. Do let me know if anything needs changing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: This client version discontinues support for Akka Streams and introduces support for Pekko Streams instead.
…4.0 (#669) * chore(deps): bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 Bumps org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…3 to 1.12.1 (#670) * chore(deps): bump io.micrometer:micrometer-registry-influx Bumps [io.micrometer:micrometer-registry-influx](https://github.com/micrometer-metrics/micrometer) from 1.11.3 to 1.12.1. - [Release notes](https://github.com/micrometer-metrics/micrometer/releases) - [Commits](micrometer-metrics/micrometer@v1.11.3...v1.12.1) --- updated-dependencies: - dependency-name: io.micrometer:micrometer-registry-influx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md [skip CI] --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…3.6.0 to 3.6.3 (#671) * chore(deps): bump org.apache.maven.plugins:maven-javadoc-plugin Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.6.0 to 3.6.3. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.6.0...maven-javadoc-plugin-3.6.3) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
* chore(deps): bump junit-jupiter.version from 5.9.1 to 5.10.1 Bumps `junit-jupiter.version` from 5.9.1 to 5.10.1. Updates `org.junit.vintage:junit-vintage-engine` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) Updates `org.junit.jupiter:junit-jupiter-engine` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) Updates `org.junit.jupiter:junit-jupiter-api` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) --- updated-dependencies: - dependency-name: org.junit.vintage:junit-vintage-engine dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
* chore(deps): bump com.squareup.okio:okio from 3.6.0 to 3.7.0 Bumps [com.squareup.okio:okio](https://github.com/square/okio) from 3.6.0 to 3.7.0. - [Changelog](https://github.com/square/okio/blob/master/CHANGELOG.md) - [Commits](square/okio@parent-3.6.0...parent-3.7.0) --- updated-dependencies: - dependency-name: com.squareup.okio:okio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md [skip CI] --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
* chore(deps): bump kotlin.version from 1.9.20 to 1.9.22 Bumps `kotlin.version` from 1.9.20 to 1.9.22. Updates `org.jetbrains.kotlin:kotlin-stdlib` from 1.9.20 to 1.9.22 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.20...v1.9.22) Updates `org.jetbrains.kotlin:kotlin-maven-plugin` from 1.9.20 to 1.9.22 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin:kotlin-stdlib dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin:kotlin-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
…4.0 (#669) * chore(deps): bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 Bumps org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
* chore(deps): bump junit-jupiter.version from 5.9.1 to 5.10.1 Bumps `junit-jupiter.version` from 5.9.1 to 5.10.1. Updates `org.junit.vintage:junit-vintage-engine` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) Updates `org.junit.jupiter:junit-jupiter-engine` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) Updates `org.junit.jupiter:junit-jupiter-api` from 5.9.1 to 5.10.1 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.1...r5.10.1) --- updated-dependencies: - dependency-name: org.junit.vintage:junit-vintage-engine dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Update CHANGELOG.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
38d8242
to
c8209ff
Compare
Hi @bednar, I've completed the checklist and rebased the commit 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utkuaydn thanks again for your PR 👍
LGTM 🚀
Well done Utku! |
Closes #660
Proposed Changes
Support for Pekko Streams in the scala client
Checklist
mvn test
completes successfully