fix(influxdb2/client): Send Content-Type headers #30
Conversation
| @@ -24,6 +24,8 @@ class DefaultApi | |||
| DEFAULT_TIMEOUT = 10 | |||
| DEFAULT_REDIRECT_COUNT = 10 | |||
|
|
|||
| HEADER_CONTENT_TYPE = 'Content-Type'.freeze | |||
| _post(payload, uri, headers: headers.merge({HEADER_CONTENT_TYPE => 'text/plain'})) | ||
| end | ||
|
|
||
| def _post(payload, uri, limit: @max_redirect_count, headers: {}) |
There was a problem hiding this comment.
what was your rationale behind creating two separate methods, _post_json and _post_text which are identical aside from content-type? keeping the original _post method and exposing a content_type named argument w/ a reasonable default (e.g. application/json) might also be worth considering? (would also provide increased flexibility in allowing _post consumers to provide different content-type headers alongside their payloads if that's ever deemed beneficial)
(i guess, on second thought, not introducing another argument dependency in favor of encapsulating the content-type-setting logic in this class is probably more robust but still curious to hear your thoughts)
There was a problem hiding this comment.
The underlying _post method is HTTP-centric so it warranted a higher-level headers concept if we are to be introducing any additional headers. However, this introduced a minor inconvenience at the JSON-based call sites so I just added some helpers.
|
@bednar eta on when 1.2 will be released? |
|
@reefloretto We will release clients at next friday, but if it is necessary We could release it early. |
We recently started requiring
Content-Typeheaders in InfluxDB 2.x API. This ensures the client is sending the appropriate headers.