Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query results has precision with nanosecond #61

Merged
merged 2 commits into from
Dec 3, 2020
Merged

fix: query results has precision with nanosecond #61

merged 2 commits into from
Dec 3, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Dec 2, 2020 •
edited
Loading

Closes #60

Proposed Changes

The query parser uses nanosecond precision for dates. - e.g. 1970-01-01T00:00:00.000123456+00:00

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar added the bug Something isn't working label Dec 2, 2020
@bednar bednar changed the title fix: query result parsed time has precision with nanosecond, e.g. '1970-01-01T00:00:00.000123456+00:00' fix: query results has precision with nanosecond, e.g. '1970-01-01T00:00:00.000123456+00:00' Dec 2, 2020
@bednar bednar changed the title fix: query results has precision with nanosecond, e.g. '1970-01-01T00:00:00.000123456+00:00' fix: query results has precision with nanosecond Dec 2, 2020
@bednar bednar marked this pull request as ready for review December 2, 2020 09:23
@bednar bednar requested a review from rhajek December 2, 2020 09:23
@bednar bednar added this to the 1.10.0 milestone Dec 2, 2020
@bednar bednar merged commit c41f7c2 into master Dec 3, 2020
@bednar bednar deleted the fix/parser-nanosecond branch December 3, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

rfc3339 time conversion removing fractional seconds from query results
2 participants
@bednar @rhajek