Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse 503 plain text error #90

Merged
merged 3 commits into from
Sep 1, 2021
Merged

fix: parse 503 plain text error #90

merged 3 commits into from
Sep 1, 2021

Conversation

rhajek
Copy link
Contributor

@rhajek rhajek commented Aug 31, 2021

Proposed Changes

This PR fixes handling of plain-text http errors.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #90 (0efef45) into master (c9a3f0a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          16       16           
  Lines         793      794    +1     
=======================================
+ Hits          785      786    +1     
  Misses          8        8           
Impacted Files Coverage Δ
lib/influxdb2/client/influx_error.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9a3f0a...0efef45. Read the comment docs.

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rhajek rhajek merged commit 3cffe85 into master Sep 1, 2021
@rhajek rhajek deleted the fix/parse_error branch September 1, 2021 08:18
@bednar bednar added this to the 2.0.0 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants