Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags should be sorted by key in line protocol to reduce db server overheads #468

Closed
lxhoan opened this issue Jul 18, 2018 · 3 comments
Closed

tags should be sorted by key in line protocol to reduce db server overheads #468

lxhoan opened this issue Jul 18, 2018 · 3 comments
Assignees
@lxhoan
Labels
kind/enhancement kind/feature-request
Milestone
2.12

Comments

@lxhoan
Copy link
Contributor

lxhoan commented Jul 18, 2018

We can replicate this telegraf enhancement to influxdb-java

InfluxDB output plugin should sort tags

according to the benchmark there seems a pretty good performance gain at server side
@lxhoan lxhoan added this to the 2.12 milestone Jul 18, 2018
@majst01
Copy link
Collaborator

majst01 commented Jul 18, 2018

Should be quite easy to implement.

@lxhoan lxhoan self-assigned this Jul 19, 2018
@lxhoan lxhoan changed the title batch writing should sort tags by key to reduce db server overheads tags should be sorted by key in line protocol to reduce db server overheads Jul 25, 2018
lxhoan added a commit to bonitoo-io/influxdb-java that referenced this issue Jul 25, 2018
@lxhoan
issue influxdata#468 tags should be sorted by key in line protocol to…
767e890 
… reduce db

server overheads
add unit test
lxhoan added a commit to bonitoo-io/influxdb-java that referenced this issue Jul 25, 2018
@lxhoan
issue influxdata#468 tags should be sorted by key in line protocol to…
ad3b2f6 
… reduce db

server overheads
add unit test
lxhoan added a commit to bonitoo-io/influxdb-java that referenced this issue Jul 25, 2018
@lxhoan
issue influxdata#468 tags should be sorted by key in line protocol to…
2d1c9bc 
… reduce db

server overheads
add unit test
majst01 added a commit that referenced this issue Jul 25, 2018
@majst01
Merge pull request #476 from bonitoo-io/tag_key_sorted
a59e4e6 
issue #468 tags should be sorted by key in line protocol to reduce db server overheads
@majst01
Copy link
Collaborator

majst01 commented Jul 25, 2018

can we close this ?

@lxhoan
Copy link
Contributor Author

lxhoan commented Jul 25, 2018

close as merged

@lxhoan lxhoan closed this as completed Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lxhoan lxhoan

Labels
kind/enhancement kind/feature-request
Projects
None yet
Milestone
2.12
Development

No branches or pull requests
2 participants
@majst01 @lxhoan