Cache cleanups #12807
Merged
Cache cleanups #12807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebo
force-pushed
the
jmw-cache-cleanups
branch
from
e305e2f
to
bf85a42
Compare
zeebo
force-pushed
the
jmw-cache-cleanups
branch
from
bf85a42
to
de700b1
Compare
benbjohnson
approved these changes
Mar 27, 2019
The code actually didn't work if 16 wasn't passed. Indeed, the benchmarks weren't even working. Fix up all that, and reduce the complexity some.
The storer interface isn't necessary if the init/Free logic is removed, which is unnecessary in a world with only one shard. Additionally, there were some cases where an init/Free call could race and cause data loss in the cache. Not doing it at all fixes all of those races.
This makes it easier and more robust to check if an error is due to the cache memory limit being exceeded.
zeebo
force-pushed
the
jmw-cache-cleanups
branch
from
48e753c
to
96a01ee
Compare
|
🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanups on the cache. Specifically
initandFreeare unnecessary and can lead to data loss in some race conditions.*ringtype only works with 16 partitions, so update the code and remove comments claiming otherwise.