Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy button to export overlays #12843

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Add copy button to export overlays #12843

merged 1 commit into from
Mar 22, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Mar 22, 2019 •
edited
Loading

Closes #12739

Screen Shot 2019-03-22 at 1 29 35 PM

Briefly describe your proposed changes:
create general copy button
add copy button to export overlays
update code snippet to use general copy button

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the feat/export-copy-button branch 2 times, most recently from c19cfdc to 2d5bd57 Compare March 22, 2019 20:23
Palakp41
Palakp41 approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@Palakp41 Palakp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ischolten ischolten merged commit 9277a76 into master Mar 22, 2019
@ischolten ischolten deleted the feat/export-copy-button branch March 22, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakp41 Palakp41 Palakp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischolten @Palakp41