Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to edit token's description #13024

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Add the ability to edit token's description #13024

merged 1 commit into from
Apr 1, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Mar 29, 2019 •
edited
Loading

Closes #10910

Briefly describe your proposed changes:

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

Kapture 2019-03-29 at 15 10 38

@Palakp41 Palakp41 force-pushed the feat/token-description-edit branch 3 times, most recently from 06270bf to 9c1c827 Compare March 29, 2019 22:16
bthesorceror
bthesorceror approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@bthesorceror bthesorceror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise 🍰

@Palakp41 Palakp41 force-pushed the feat/token-description-edit branch 2 times, most recently from 5bbab08 to 2683651 Compare April 1, 2019 16:26
@Palakp41 Palakp41 merged commit 28b9e4f into master Apr 1, 2019
@Palakp41 Palakp41 deleted the feat/token-description-edit branch May 21, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthesorceror bthesorceror bthesorceror approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Palakp41 @bthesorceror